Import tendril crate#662
Conversation
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Thanks. I'm definitely in favor of this and archiving the tendril repository. I just have one request:
| name: Tendril CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| workflow_dispatch: | ||
| merge_group: | ||
| types: [checks_requested] | ||
|
|
||
| jobs: | ||
| linux-ci: | ||
| name: Linux | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| toolchain: ["stable", "beta", "nightly", "1.36.0"] | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Install toolchain | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| profile: minimal | ||
| toolchain: ${{ matrix.toolchain }} |
There was a problem hiding this comment.
Would it be possible to integrate this into the html5ever CI?
There was a problem hiding this comment.
Changes made:
- Remove
tendril.ymlworkflow - Add step for
cargo test --features 'encoding encoding_rs' - Port tendril benchmarks to criterion (which means they get picked up by html5ever's CI without any changes to the config)
I have not attempted to maintain the Rust 1.36 check as given that tendril is basically only used by html5ever, it doesn't seem useful to maintain a lower MSRV.
nicoburns
force-pushed
the
tendril
branch
5 times, most recently
from
8fba460 to
551389b
Compare
| #[cfg(any(feature = "encoding", feature = "encoding_rs"))] | ||
| pub type Tests = &'static [(&'static [&'static [u8]], &'static str, usize)]; | ||
|
|
||
| #[cfg(any(feature = "encoding"))] |
There was a problem hiding this comment.
For some reason ignoring the clippy lint for this didn't work. So I just fixed it instead.
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
|
This is now passing CI and ready for review. I have intentionally made as few changes as possible to the code in https://github.com/servo/tendril in this PR so as to maintain history. So I have ignored warning and clippy lints rather than fixing them, haven't updated dependencies, or migrated edition etc. Those changes can be made in follow-up PRs. We may also wish to consider rebase-merging rather than squash-merging this PR for the same reason. Once this PR is merged we should:
|
2 participants
The
tendrilcrate is an important servo-owned dependency ofhtml5ever, not widely used outside ofhtml5ever, and is poorly maintained in it's current home of https://github.com/servo/tendril (which is somewhat concerning given that it contains a large amount ofunsafecode).This PR imports the
tendrilcrate into this repository where it can hopefully get more attention.